[grisbi-bugs] [Grisbi 0001743]: Crash when importing ofx file

[Grisbi Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://www.grisbi.org/bugsreports/view.php?id=1743 
====================================================================== 
Reported By:                BaDuf
Assigned To:                pbiava
====================================================================== 
Project:                    Grisbi
Issue ID:                   1743
Category:                   Main
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     assigned
OS:                         Ubuntu 
Unstable Impact:            Yes 
Version OS:                 17.04 
Version GTK:                 
====================================================================== 
Date Submitted:             2017-09-04 21:28 CEST
Last Modified:              2017-09-06 20:40 CEST
====================================================================== 
Summary:                    Crash when importing ofx file
Description: 
Grisbi crash when trying to import ofx file. Everything works well until Grisbi
says that the import configuration is finished, then I click on finish and
Grisbi crashs with the following error message :
"Grisbi a terminé son exécution en raison d'une erreur de segmentation
(segmentation fault I presume)." Here is the trace :
grisbi(+0x28d4e) [0x555958ad4d4e]
	/lib/x86_64-linux-gnu/libc.so.6(+0x357f0) [0x7fa210e417f0]
	grisbi(+0x3aa85) [0x555958ae6a85]
	grisbi(+0x745a5) [0x555958b205a5]
	grisbi(+0x766a0) [0x555958b226a0]
	/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0(g_closure_invoke+0x145)
[0x7fa211e99c25]
	/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0(+0x21c32) [0x7fa211eabc32]
	/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0(g_signal_emit_valist+0xe3c)
[0x7fa211eb488c]
	/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0(g_signal_emit+0x8f)
[0x7fa211eb4c6f]
	/usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0(+0x74760) [0x7fa21312b760]
	/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0(g_closure_invoke+0x145)
[0x7fa211e99c25]
	/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0(+0x2160c) [0x7fa211eab60c]
	/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0(g_signal_emit_valist+0xe3c)
[0x7fa211eb488c]
	/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0(g_signal_emit+0x8f)
[0x7fa211eb4c6f]
	/usr/lib/x86_64-linux-gnu/libunity-gtk2-parser.so.0(+0x43b0) [0x7fa206e223b0]

It seems that this occurs when I import long ofx files (operations for a whole
month, that is around http://www.grisbi.org/bugsreports/view.php?id=20#c30
operations). I tried with a small one (5 operations) and everything worked.

Many thanks in advance for your help.

Steps to Reproduce: 
- click on "import file" in the file menu, then "next".
- choose the ofx file to be imported, then "next".
- Importation done, click "next".
- Select the third option "mark operation of the following account", then
"next".
- Success, click on "finish".
-> Crash

Additional Information: 
If needed, I can send you the ofx file.
Notice that the web adress given in the error message to report bug is wrong. It
is said "grisbi.org/bugtracking" instead of "grisbi.org/bugreports".
====================================================================== 

---------------------------------------------------------------------- 
 (0003916) pbiava (administrator) - 2017-09-05 14:33
 http://www.grisbi.org/bugsreports/view.php?id=1743#c3916 
---------------------------------------------------------------------- 
peux-tu m'envoyer ton fichier à l'adresse ci dessous ?

pierre at pierre.biava.name

can you send me your file to the address above? 

---------------------------------------------------------------------- 
 (0003917) BaDuf (reporter) - 2017-09-05 16:27
 http://www.grisbi.org/bugsreports/view.php?id=1743#c3917 
---------------------------------------------------------------------- 
Je viens d'envoyer le fichier ofx.

Merci d'avance. 

---------------------------------------------------------------------- 
 (0003918) pbiava (administrator) - 2017-09-05 19:47
 http://www.grisbi.org/bugsreports/view.php?id=1743#c3918 
---------------------------------------------------------------------- 
Bon en fait le fichier OFX est mal fait. Il manque une information sur le
charset.

En attendant la correction tu peux ajouter au début du fichier la lligne
suivante :
CHARSET:1252

ce qui donne :
CHARSET:1252
<OFX>
<SIGNONMSGSRSV1>
<SONRS>

ça devrait fonctionner. 

---------------------------------------------------------------------- 
 (0003919) BaDuf (reporter) - 2017-09-06 20:40
 http://www.grisbi.org/bugsreports/view.php?id=1743#c3919 
---------------------------------------------------------------------- 
Bonjour,

Excellente nouvelle !
Le fichier est fourni directement par la banque (CA). Je ne suis que moyennement
surpris par le fait qu'il soit mal fait (à noter que la banque propose 3
"formats" ofx différents : ofx-money, ofx-quicken, ofx-isacompta. Mais les 3
posent le meme soucis ;-) ).

Je testerai ta solution le mois prochain lors du prochain relevé (je ne peux
pas tester maintenant car je viens de terminer le rapprochement à la main), et
te tiendrais au courant du résultat.

Merci beaucoup,

Basile 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2017-09-04 21:28 BaDuf          New Issue                                    
2017-09-05 14:31 pbiava         Assigned To               => pbiava          
2017-09-05 14:31 pbiava         Status                   new => assigned     
2017-09-05 14:33 pbiava         Note Added: 0003916                          
2017-09-05 16:27 BaDuf          Note Added: 0003917                          
2017-09-05 19:47 pbiava         Note Added: 0003918                          
2017-09-06 20:40 BaDuf          Note Added: 0003919                          
======================================================================