[grisbi-bugs] [Grisbi-0.6.0 0001097]: Build fails on F-13 because of implicit linking

[bugtracker at grisbi.org]

The following issue has been RESOLVED. 
====================================================================== 
http://grisbi.tuxfamily.org/mantis/view.php?id=1097 
====================================================================== 
Reported By:                abompard
Assigned To:                pbiava
====================================================================== 
Project:                    Grisbi-0.6.0
Issue ID:                   1097
Category:                   Main
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     resolved
Plateforme:                 Linux 
OS:                         Fedora 
Version OS:                 13 
Unstable Impact:            Yes 
Version GTK:                 
Resolution:                 fixed
Fixed in Version:           CVS (développement)
====================================================================== 
Date Submitted:             05-21-2010 06:31 UTC
Last Modified:              06-03-2010 20:20 UTC
====================================================================== 
Summary:                    Build fails on F-13 because of implicit linking
Description: 
On Fedora 13, the implicit linking feature of LD has been disabled. The
reason, from the fedora wiki page
http://fedoraproject.org/wiki/UnderstandingDSOLinkChange is :

The default behaviour for ld allows users to 'indirectly' link to required
objects/libraries through intermediate objects/libraries. While this is
convenient, it can also be dangerous because it makes your program's
dependencies tied to the dependencies of other objects. If those objects
ever change their linkages, they can break your program without any changes
to your own code.

Grisbi is affected, I've attached a patch to fix the build. Feel free to
adapt it as needed, I'm no autoconf expert.

Err... I tried to attache the patch to Mantis but it fails (APPLICATION
ERROR http://grisbi.tuxfamily.org/mantis/view.php?id=504 -- No file was
uploaded. Please go back and Choose a file before
pressing Upload), so I'll cut-n-paste it here :
------8<-----------8<-------------8<---------------8<----------------
--- configure.in.dso    2010-04-28 18:19:58.000000000 +0200
+++ configure.in        2010-05-20 08:48:19.619648407 +0200
@@ -261,6 +261,8 @@
 AC_SUBST(GSB_NOOPTIM)
 
 
+# Avoid implicit dynamic linking
+LDFLAGS="${LDFLAGS} -lm -lz"
 
 AC_SUBST(GTK_LIBS)
 AC_SUBST(GTK_CFLAGS)
------8<-----------8<-------------8<---------------8<----------------
====================================================================== 

---------------------------------------------------------------------- 
 abompard - 05-21-10 06:34  
---------------------------------------------------------------------- 
It looks like all my failed attempts at attaching a file have actually
created tickets ! Sorry about that, please close tickets from 1092 to 1096.
I can't even do it myself... :-( 

---------------------------------------------------------------------- 
 pbiava - 05-27-10 20:01  
---------------------------------------------------------------------- 
hi,

It's fixed on cvs. Can you test this new version 

---------------------------------------------------------------------- 
 pbiava - 06-03-10 20:20  
---------------------------------------------------------------------- 
fixed in cvs and git 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-21-10 06:31  abompard       New Issue                                    
05-21-10 06:31  abompard       Plateforme                => Linux           
05-21-10 06:31  abompard       OS                        => Fedora          
05-21-10 06:31  abompard       Version OS                => 13              
05-21-10 06:31  abompard       Unstable Impact           => Yes             
05-21-10 06:34  abompard       Note Added: 0002401                          
05-21-10 06:34  abompard       Issue Monitored: abompard                    
05-21-10 19:03  pbiava         Status                   new => assigned     
05-21-10 19:03  pbiava         Assigned To               => pbiava          
05-27-10 20:01  pbiava         Note Added: 0002431                          
06-03-10 20:20  pbiava         Status                   assigned => resolved
06-03-10 20:20  pbiava         Fixed in Version          => CVS (développement)
06-03-10 20:20  pbiava         Resolution               open => fixed       
06-03-10 20:20  pbiava         Note Added: 0002453                          
======================================================================